Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB update not working #491

Closed
wants to merge 1 commit into from

Conversation

herobank110
Copy link

@herobank110 herobank110 commented Sep 23, 2024

'WHERE' parsing was removing the closing paren of object IDs

eg _id = MongoDB\BSON\ObjectID("66d5e4468b906497efb4cb93"

peterpp added a commit to adminerneo/adminerneo that referenced this pull request Nov 9, 2024
@peterpp
Copy link
Contributor

peterpp commented Nov 10, 2024

Thanks for sharing. I'm not sure why that regexp removes parenthesis. I suppose that the condition can be "WHERE ((a=1) OR (b=2))", so I've kept previous logic in my fix here: adminerneo@c5937fc

peterpp added a commit to adminerneo/adminerneo that referenced this pull request Nov 10, 2024
peterpp added a commit to adminerneo/adminerneo that referenced this pull request Nov 19, 2024
vrana pushed a commit that referenced this pull request Feb 19, 2025
@vrana
Copy link
Owner

vrana commented Feb 19, 2025

Merged, thanks.

@vrana vrana closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants