Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Groups API #197

Merged
merged 40 commits into from
Dec 2, 2022
Merged

Basic Groups API #197

merged 40 commits into from
Dec 2, 2022

Conversation

Miner28
Copy link
Collaborator

@Miner28 Miner28 commented Dec 1, 2022 •
edited by Foorack
Loading

Issue #198

Foorack
Foorack requested changes Dec 1, 2022
View reviewed changes
Copy link
Member

@Foorack Foorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job from both @ariesclark and @Miner28 !!

Please look at the comments for further feedback.

openapi/components/paths.yaml Outdated Show resolved Hide resolved
openapi/components/paths/groups.yaml Show resolved Hide resolved
openapi/components/paths/groups.yaml Show resolved Hide resolved
openapi/components/paths/users.yaml Outdated Show resolved Hide resolved
openapi/components/paths/users.yaml Outdated Show resolved Hide resolved
openapi/components/responses/groups/GroupNotFoundError.yaml Show resolved Hide resolved
@Foorack Foorack mentioned this pull request Dec 1, 2022
Closed
@Miner28 Miner28 changed the title Groups API, Create, List Basic Groups API Dec 2, 2022
@ariesclark
Copy link
Member

👏 looks awesome so far :)

ariesclark
ariesclark requested changes Dec 2, 2022
View reviewed changes
openapi/components/requests/CreateGroupRoleRequest.yaml Outdated Show resolved Hide resolved
openapi/components/requests/CreateGroupInviteRequest.yaml Outdated Show resolved Hide resolved
openapi/components/paths/users.yaml Outdated Show resolved Hide resolved
openapi/components/paths/users.yaml Show resolved Hide resolved
openapi/components/paths/groups.yaml Outdated Show resolved Hide resolved
openapi/components/paths/groups.yaml Outdated Show resolved Hide resolved
Foorack
Foorack approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@Foorack Foorack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not entirely solve #198 , but nor do I think it should. This is a good starting point for documenting the Group API, due to it's size. I would be happy to merge this now in the current state it is in.

Just because we merge something into main does not mean it goes into live. For that we need to create a Release, so don't worry, we can develop on main as long as tests pass.

Thanks for fantastic work everyone! ❤️ @Miner28 @ariesclark I think this is the best real-time API documentation collaboration I have seen in a long time.

Foorack
Foorack approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@Foorack Foorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Foorack Foorack enabled auto-merge (squash) December 2, 2022 21:00
ariesclark
ariesclark approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@ariesclark ariesclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏

@Foorack Foorack merged commit 59d69fc into vrchatapi:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foorack Foorack Foorack approved these changes

@ariesclark ariesclark ariesclark approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Miner28 @ariesclark @Foorack