fix delete contain internal columns panic (databendlabs#12833)

src/query/sql/src/planner/binder/bind_context.rs

@@ -139,6 +139,7 @@ pub struct BindContext {
 
     pub expr_context: ExprContext,
 
+    pub allow_internal_columns: bool,
     /// If true, the query is planning for aggregate index.
     /// It's used to avoid infinite loop.
     pub planning_agg_index: bool,
@@ -171,6 +172,7 @@ impl BindContext {
             lambda_info: LambdaInfo::default(),
             cte_name: None,
             cte_map_ref: Box::default(),
+            allow_internal_columns: true,
             in_grouping: false,
             view_info: None,
             srfs: DashMap::new(),
@@ -190,6 +192,7 @@ impl BindContext {
             lambda_info: LambdaInfo::default(),
             cte_name: parent.cte_name,
             cte_map_ref: parent.cte_map_ref.clone(),
+            allow_internal_columns: parent.allow_internal_columns,
             in_grouping: false,
             view_info: None,
             srfs: DashMap::new(),
@@ -222,6 +225,10 @@ impl BindContext {
         self.columns.push(column_binding);
     }
 
+    pub fn allow_internal_columns(&mut self, allow: bool) {
+        self.allow_internal_columns = allow;
+    }
+
     /// Apply table alias like `SELECT * FROM t AS t1(a, b, c)`.
     /// This method will rename column bindings according to table alias.
     pub fn apply_table_alias(
@@ -507,6 +514,13 @@ impl BindContext {
         column_binding: &InternalColumnBinding,
         metadata: MetadataRef,
     ) -> Result<ColumnBinding> {
+        if !self.allow_internal_columns {
+            return Err(ErrorCode::SemanticError(format!(
+                "Internal column `{}` is not allowed in current statement",
+                column_binding.internal_column.column_name()
+            )));
+        }
+
         let column_id = column_binding.internal_column.column_id();
         let (table_index, column_index, new) = match self.bound_internal_columns.entry(column_id) {
             btree_map::Entry::Vacant(e) => {

src/query/sql/src/planner/binder/delete.rs

@@ -81,6 +81,7 @@ impl<'a> Binder {
             .bind_table_reference(bind_context, table_reference)
             .await?;
 
+        context.allow_internal_columns(false);
         let mut scalar_binder = ScalarBinder::new(
             &mut context,
             self.ctx.clone(),

src/query/sql/src/planner/binder/table.rs

@@ -820,6 +820,7 @@ impl Binder {
             srfs: Default::default(),
             expr_context: ExprContext::default(),
             planning_agg_index: false,
+            allow_internal_columns: true,
             window_definitions: DashMap::new(),
         };
 

src/query/sql/src/planner/binder/update.rs

@@ -71,6 +71,7 @@ impl Binder {
             .get_table(&catalog_name, &database_name, &table_name)
             .await?;
 
+        context.allow_internal_columns(false);
         let mut scalar_binder = ScalarBinder::new(
             &mut context,
             self.ctx.clone(),

tests/sqllogictests/suites/base/03_common/03_0025_delete_from

@@ -294,6 +294,9 @@ insert into t select c + 1000000 from t_number;
 statement ok
 delete from t where c >= 0 and c < 1500000;
 
+statement error 1065
+delete from t where _row_id = 18446735277616529408;
+
 query I
 select count(*) from t;
 ----