Skip to content

Commit

Permalink
Added consumed signal to RecordAndSubmitTask submission.
Browse files Browse the repository at this point in the history
  • Loading branch information
robertosfield committed Sep 13, 2024
1 parent 66ba870 commit c8bfbc5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
14 changes: 11 additions & 3 deletions src/vsg/app/RecordAndSubmitTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ VkResult RecordAndSubmitTask::submit(ref_ptr<FrameStamp> frameStamp)
{
CPU_INSTRUMENTATION_L1_NC(instrumentation, "RecordAndSubmitTask submit", COLOR_RECORD);

//info("RecordAndSubmitTask::submit()");
info("\nRecordAndSubmitTask::submit()");

if (VkResult result = start(); result != VK_SUCCESS) return result;

Expand All @@ -96,6 +96,7 @@ VkResult RecordAndSubmitTask::submit(ref_ptr<FrameStamp> frameStamp)
{
//info(" adding early transfer dataTransferredSemaphore ", transfer.dataTransferredSemaphore);
transientWaitSemaphores.push_back(transfer.dataTransferredSemaphore);
dataTransferred = true;
}
}
else
Expand Down Expand Up @@ -153,7 +154,7 @@ VkResult RecordAndSubmitTask::finish(ref_ptr<RecordedCommandBuffers> recordedCom
{
CPU_INSTRUMENTATION_L1_NC(instrumentation, "RecordAndSubmitTask finish", COLOR_RECORD);

//info("RecordAndSubmitTask::finish()");
info("RecordAndSubmitTask::finish()");

auto current_fence = fence();

Expand All @@ -167,6 +168,7 @@ VkResult RecordAndSubmitTask::finish(ref_ptr<RecordedCommandBuffers> recordedCom
if (transfer.dataTransferredSemaphore)
{
//info(" adding late transfer dataTransferredSemaphore ", transfer.dataTransferredSemaphore);
dataTransferred = true;
transientWaitSemaphores.push_back(transfer.dataTransferredSemaphore);
}
}
Expand Down Expand Up @@ -239,9 +241,15 @@ VkResult RecordAndSubmitTask::finish(ref_ptr<RecordedCommandBuffers> recordedCom
vk_signalSemaphores.emplace_back(*semaphore);
current_fence->dependentSemaphores().push_back(semaphore);
}

transientSignalSemaphores.clear();

if (dataTransferred)
{
vk_signalSemaphores.emplace_back(transferConsumerCompletedSemaphore->vk());
}



VkSubmitInfo submitInfo = {};
submitInfo.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;

Expand Down
2 changes: 1 addition & 1 deletion src/vsg/app/TransferTask.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ TransferTask::TransferTask(Device* in_device, uint32_t numBuffers) :
_lateDataToCopy.frames.emplace_back(TransferBlock::create());
}

// level = Logger::LOGGER_INFO;
level = Logger::LOGGER_INFO;
}

void TransferTask::advance()
Expand Down

0 comments on commit c8bfbc5

Please sign in to comment.