feat: Disable Service Links by default #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the default configuration, Kubernetes will inject a bunch of environment variables for each service in the Namespace. The idea is to aid with service discovery, but while they are rarely used in practice, the injected environment variables might interfere that try to determine their configuration from environment variables. This commit disables this behaviour by default by setting `enableServiceLinks: false` in the pod specs, but allows users to reenable the links using a label. Signed-off-by: Manuel Hutter <[email protected]>
|
LGTM, feel free to merge. |
|
Is this a breaking change? 🤔 It affects the current behavior, but one that was probably not used much in the first place (at least never by us) |
|
I thought about that too, but from what I can tell the service links in k8s are largely a legacy feature that isn't/shouldn't be used, so I'd release this as a non-breaking change, even though in theory it could be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the default configuration, Kubernetes will inject a bunch of environment variables for each service in the Namespace. The idea is to aid with service discovery, but while they are rarely used in practice, the injected environment variables might interfere that try to determine their configuration from environment variables.
This commit disables this behaviour by default by setting
enableServiceLinks: falsein the pod specs, but allows users to reenable the links using a label.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog