Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pullsecret reference naming #163

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Fix pullsecret reference naming #163

merged 2 commits into from
Feb 20, 2025

Conversation

martini-source
Copy link
Member

Summary

Fix to properly reference imagePullSecrets

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@martini-source martini-source self-assigned this Feb 20, 2025
@martini-source martini-source added the bug Something isn't working label Feb 20, 2025
davidgubler
davidgubler reviewed Feb 20, 2025
View reviewed changes
@davidgubler
Copy link
Member

LGTM.

@martini-source martini-source merged commit ae3783f into master Feb 20, 2025
4 checks passed
@martini-source martini-source deleted the fix/pullsecret branch February 20, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgubler davidgubler davidgubler left review comments

@mhutter mhutter Awaiting requested review from mhutter

Assignees

@martini-source martini-source

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martini-source @davidgubler