Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Dataset class, avoiding all the 'if condition: continue' and allow deterministic idx #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laurentbenaroya
Copy link

In the file train_vocalist_lrs2.py, in the __getitem__ method of the Dataset class, an idx index was drawn at random, even though idx was supplied as input to the method. As a result, a while True is required and a lot of conditions that lead to a continue if they are not met. I replaced all this with assert not condition, which allowed me to debug the Dataset class.
This has been done in train_vocalist_lrs2.py and could be extended to train_vocalist_acappella.py (if the PR is accepted).
Note small changes in train and eval_model functions (cosmetic).

…condition (debugging work) + cosmetic changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant