-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load Mega Menu Items Server-Side #35
Open
RobertIviteb
wants to merge
15
commits into
vtex-apps:master
Choose a base branch
from
iviteb:feature/ssr-load-menu-dom
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this solving?
It loads the items of the mega menu both client side and server side when the page is initialized; this includes all departments, categories, subcategories. In other words, when the page loads, the mega menu items are already in the DOM. This is needed for SEO purposes.
A client requested this feature for SEO optimization.
How should this be manually tested?
The mega menu needs to be already set up,
vtex-mega-menu-2-x-styledLinkText
and you will see multiple matches. These are the menu items already loaded in the DOM.Screenshots or example usage:
This mega menu has 1 department, 1 category and 1 subcategory. In the image you can see 1 of 3 so it loaded all the items.
Same for the page source, 1 of 3.
This is the menu with 3 total items: