Fix/SKU selector classname #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
ataideverton
requested changes
Jun 6, 2024
react/AutocompleteBlock.tsx
Outdated
| @@ -341,7 +342,7 @@ const AutocompleteBlock: FunctionComponent<any & WrappedComponentProps> = ({ | |||
| return ( | |||
| <span | |||
| key={item.itemId} | |||
| className={`mr4 ${handles.skuSelection}`} | |||
| className={`mr4 ${handles.skuSelection} ${item.itemId === selectedItem.value && handles.skuSelectionSelected}`} | |||
There was a problem hiding this comment.
The goal here is to just add a true or false to the className?
There was a problem hiding this comment.
Yes! Only to get when is selected
Co-authored-by: ataideverton <[email protected]>
…elRamos115/quickorder into fix/sku-selector-classname
|
ataideverton
previously approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? *
Adds a class to the selected sku to make it possible to change its color for other stores with different color palettes
How to test it? *
There is no way to test for sure, you would just use the class to change the color when necessary
Describe alternatives you've considered, if any. *
Related to / Depends on *