-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return from skuFromRefIds #169
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
node/resolvers/search/index.ts
Outdated
items = result.map((item: { sellers: any[] }) => ({ | ||
...item, | ||
sellers: item.sellers?.filter((seller: any) => | ||
'availability' in seller && | ||
seller.availability !== null | ||
) || [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a comment explaining what/why we are doing here exactly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
8eb7b85
to
96644e3
Compare
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What does this PR do? *
Fix the return from getSkuSellerInfo
Before change:
BEFORE.CHANGE.mov
After change:
AFTER.CHANGE.mov
How to test it? *
Try copy/paste skus 880010a (inactive product), 880010v(product not registered) and 880020a(product without stock) on this workspace
Describe alternatives you've considered, if any. *
Related to / Depends on *