Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return from skuFromRefIds #169

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

giurigaud
Copy link
Contributor

What does this PR do? *

Fix the return from getSkuSellerInfo

Before change:

BEFORE.CHANGE.mov

After change:

AFTER.CHANGE.mov

How to test it? *

Try copy/paste skus 880010a (inactive product), 880010v(product not registered) and 880020a(product without stock) on this workspace

Describe alternatives you've considered, if any. *

Related to / Depends on *

Copy link

vtex-io-ci-cd bot commented Sep 18, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Sep 18, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Comment on lines 304 to 311
items = result.map((item: { sellers: any[] }) => ({
...item,
sellers: item.sellers?.filter((seller: any) =>
'availability' in seller &&
seller.availability !== null
) || []

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a comment explaining what/why we are doing here exactly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ataideverton
ataideverton previously approved these changes Sep 30, 2024
Copy link

github-actions bot commented Oct 2, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 27, PR deletions = 12

Generated by 🚫 dangerJS against 96644e3

@ataideverton ataideverton merged commit d47b294 into vtex-apps:master Oct 2, 2024
17 of 19 checks passed
Copy link

vtex-io-ci-cd bot commented Oct 2, 2024

Your PR has been merged! App is being published. 🚀
Version 3.15.7 → 3.15.8

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants