Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all translations v2 #687

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Fix all translations v2 #687

merged 4 commits into from
Nov 7, 2024

Conversation

salesfelipe
Copy link
Contributor

@salesfelipe salesfelipe commented Nov 7, 2024

What problem is this solving?

Review and fix all translations. Tracked in task LOC-16956

A new version of #684 rebased with the latest master

How to test it?

[Workspace](Link goes here!)

Screenshots or example usage:

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@salesfelipe salesfelipe requested review from a team as code owners November 7, 2024 14:38
@salesfelipe salesfelipe requested review from gabpaladino, vsseixaso and RodrigoTadeuF and removed request for a team November 7, 2024 14:38
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 7, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Nov 7, 2024

Warnings
⚠️

👀 The size of this pull request seems relatively large (>420 modifications). Consider splitting it into smaller pull requests to help make reviews easier and faster.

Generated by 🚫 dangerJS against f9e10d1

@salesfelipe salesfelipe changed the title Fix/l10n fix Fix all translations v2 Nov 7, 2024
Copy link
Collaborator

@sheilagomes sheilagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salesfelipe salesfelipe merged commit b947b98 into master Nov 7, 2024
8 checks passed
@salesfelipe salesfelipe deleted the fix/l10n-fix branch November 7, 2024 15:01
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 7, 2024

Your PR has been merged! App is being published. 🚀
Version 3.134.0 → 3.134.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@salesfelipe salesfelipe mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants