Skip to content

Commit

Permalink
Merge pull request #4 from vtex-apps/change-css-handles-version
Browse files Browse the repository at this point in the history
Change css handles version
  • Loading branch information
luarakerlen authored Nov 14, 2024
2 parents 2e5d8ae + 76e6c1b commit a29d5d6
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 14 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Downgrade `vtex.css-handles` version.

## [0.0.4] - 2024-11-07

### Removed
Expand Down
6 changes: 2 additions & 4 deletions manifest.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,10 @@
"dependencies": {
"vtex.device-detector": "0.x",
"vtex.styleguide": "9.x",
"vtex.css-handles": "1.x",
"vtex.css-handles": "0.x",
"vtex.adserver-graphql": "0.x"
},
"registries": [
"smartcheckout"
],
"registries": ["smartcheckout"],
"policies": [],
"$schema": "https://raw.githubusercontent.com/vtex/node-vtex-api/master/gen/manifest.schema"
}
3 changes: 1 addition & 2 deletions react/components/SponsoredBanner/SponsoredBanner.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ import { useSponsoredBanner } from './useSponsoredBanner'
import { getDataProperties } from '../../utils'
import type { SponsoredBannersProps } from '../../interfaces'

import './styles.css'

const CSS_HANDLES = ['bannerWrapper', 'bannerImage'] as const

export const SponsoredBanner = (props: SponsoredBannersProps) => {
Expand Down Expand Up @@ -36,6 +34,7 @@ export const SponsoredBanner = (props: SponsoredBannersProps) => {
maxWidth: banner.advertisement.width,
height: 'auto',
aspectRatio: `${styleProps.ratio}`,
margin: '0 auto',
}}
>
{loading ? (
Expand Down
3 changes: 0 additions & 3 deletions react/components/SponsoredBanner/styles.css

This file was deleted.

1 change: 0 additions & 1 deletion react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"react-apollo": "^3.1.3",
"react-dom": "^16.12.0",
"react-intl": "^3.12.0",
"vtex.css-handles": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.css-handles",
"vtex.styleguide": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.styleguide",
"vtex.adserver-graphql": "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.adserver-graphql"
},
Expand Down
4 changes: 0 additions & 4 deletions react/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6055,10 +6055,6 @@ [email protected]:
version "0.3.1"
resolved "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.adserver-graphql#7bc21e63846ac77bf60d1d873e9f7fd3917b2707"

"vtex.css-handles@http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.css-handles":
version "1.0.0"
resolved "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.css-handles#336b23ef3a9bcb2b809529ba736783acd405d081"

"vtex.styleguide@http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.styleguide":
version "9.146.9"
resolved "http://vtex.vtexassets.com/_v/public/typings/v1/[email protected]/public/@types/vtex.styleguide#d1601fedfb665c6173334753171717da64e670bc"
Expand Down

0 comments on commit a29d5d6

Please sign in to comment.