Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(SSR): remove slow regular expression for escapeHtml #12507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(SSR): remove slow regular expression for escapeHtml #12507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions packages/shared/src/escapeHtml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,11 @@
const escapeRE = /["'&<>]/

export function escapeHtml(string: unknown): string {
const str = '' + string
const match = escapeRE.exec(str)

if (!match) {
return str
}

let html = ''
let escaped: string
let index: number
let lastIndex = 0
for (index = match.index; index < str.length; index++) {
for (index = 0; index < str.length; index++) {
switch (str.charCodeAt(index)) {
case 34: // "
escaped = '&quot;'
Expand Down
Loading