fix(runtime-core): modify the patchFlag of the label containing the ref attribute
#9240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
Alfred-Skyblue
force-pushed
the
fix-unmount-child
branch
from
80a2c6b to
5bc5981
Compare
edison1105
requested changes
Sep 18, 2023
Alfred-Skyblue
force-pushed
the
fix-unmount-child
branch
from
5bc5981 to
0bdfa66
Compare
Alfred-Skyblue
changed the title
v-forpatchFlag of the label containing the ref attribute
Alfred-Skyblue
force-pushed
the
fix-unmount-child
branch
from
1d323c9 to
27168fa
Compare
edison1105
approved these changes
Sep 19, 2023
| @@ -597,6 +597,7 @@ export function buildProps( | |||
| } | |||
|
|
|||
| if (isVBind && isStaticArgOf(arg, 'ref') && context.scopes.vFor > 0) { | |||
| hasRef = true | |||
There was a problem hiding this comment.
The tests all seem to pass even if this line is omitted. Perhaps there should be another test case added to cover this scenario too?
There was a problem hiding this comment.
Here is to address the issue at #9239 (comment), the function cannot be resolved in compile so I can't add a unit test for it.
| @@ -747,7 +748,7 @@ export function buildProps( | |||
| } | |||
| } | |||
| if ( | |||
| !shouldUseBlock && | |||
| !(shouldUseBlock && !hasRef) && | |||
There was a problem hiding this comment.
I'm unclear why hasRef has been singled out for special treatment. Two lines down from here, we check for hasRef || hasVnodeHook || runtimeDirectives.length > 0. Don't we have the same problem for hasVnodeHook and runtimeDirectives.length > 0?
- VNode hook example: SFC Playground
- Runtime directive example: SFC Playground
In both cases, the key seems to prevent unmounted being triggered.
pikax
added
need test
|
Resolved in #11682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #9239