Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove resize event listener when unmounted #2495

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

Alfred-Skyblue
Copy link
Member

Remove event listeners from the Repl when unMounted to prevent memory leaks.

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 5b111ea
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/64f726d561d9a70008863b38
😎 Deploy Preview https://deploy-preview-2495--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alfred-Skyblue thank you for this addition!

@NataliaTepluhina NataliaTepluhina merged commit 6d12f2c into vuejs:main Sep 19, 2023
5 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the fix-window-resize branch December 21, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants