Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update DocSearch version #4237

Merged
merged 2 commits into from
Sep 28, 2024
Merged

chore: update DocSearch version #4237

merged 2 commits into from
Sep 28, 2024

Conversation

shortcuts
Copy link
Contributor

Description

This PR updates DocSearch to its latest version.

There was a regression on the DocSearch indexing side, which broke the lvl0 header (used to create search results section). We released a library side fix in order to prevent impacting the quality of the searches in the meantime of the indexing fix, and also prevent future regressions.

I also updated your Crawler config (cc @yyx990803), so that search results are not grouped under documentation, but the same nav title as the website's sidebar

A release of vitepress with this fix applied should also fix the https://vuejs.org/ and other vitepress powered websites

Preview

The current https://vitepress.dev/ results:

Screenshot 2024-09-28 at 16 24 43

With the fix applied:

Screenshot 2024-09-28 at 16 25 09

Copy link
Member

@brc-dd brc-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@brc-dd brc-dd merged commit 7ec3be3 into vuejs:main Sep 28, 2024
8 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants