feat: on demand social icons #4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4256
closes #4135
closes #4076
closes #3809
closes #3750
closes #1214
better implements #2768 (was reverted in #2861)
vitepress installation size will increase, but this will significantly reduce the maintenance burden.
and third party themes can also use this feature. See changes in VPSocialLink.vue.
downside of this approach is that the vp-icons.css is not fingerprinted.
and the icon stuff for dev and dynamic things is bit hacky. iconify's component handles that very well, but that's another 20KB bundle + 214KB installation size, and considering that most people won't be using that part in prod, it seems unnecessary to increase bundle size.