VL-161_Add-label-slot-to-ULabel-component_Vitalii-Dudnik #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ui.form-label/ULabel.vue
Outdated
| v-bind="labelAttrs" | ||
| :data-test="`${dataTest}-label`" | ||
| v-text="label" | ||
| /> |
There was a problem hiding this comment.
no, need to add slot inside of the label tag to keep label functionality and allow to place inside some custom component if needs.
<label
v-if="label"
:for="props.for"
v-bind="labelAttrs"
:data-test="`${dataTest}-label`"
>
<!-- @slot Use it to add something instead of label. + !!!define label slot prop-->
<slot name="label" :label="label">
{{ label }}
</slot>
</label>
src/ui.form-label/ULabel.vue
Outdated
| :for="props.for" | ||
| v-bind="labelAttrs" | ||
| :data-test="`${dataTest}-label`" | ||
| v-text="label" |
| SlotLabel.args = { | ||
| slotTemplate: ` | ||
| <template #label> | ||
| <ULink label="Link component label" color="green" /> |
There was a problem hiding this comment.
better to place inside UBadge for example and set to it label from ULabel component
src/ui.button-toggle/UToggle.vue
Outdated
| @@ -86,6 +86,11 @@ const { toggleLabelAttrs, itemsAttrs, itemAttrs } = useUI<Config>(defaultConfig) | |||
| v-bind="toggleLabelAttrs" | |||
| :data-test="dataTest" | |||
| > | |||
| <template #label> | |||
| <!-- @slot Use it to add something instead of label. --> | |||
There was a problem hiding this comment.
Use this to add custom content instead of the label. - change for all translations.
and label slot props should be documented.
itsJohnnyGrid
approved these changes
Jan 2, 2025
itsJohnnyGrid
deleted the
VL-161_Add-label-slot-to-ULabel-component_Vitalii-Dudnik
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new "label" slot to ULabel component, add new story
https://ilevel.atlassian.net/jira/software/c/projects/VL/boards/11?selectedIssue=VL-161