F1828_Fixed-issue-when-dropdown-item-click-wasnt-triggered_Dmytro_Holdobin #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ui.dropdown-badge/index.vue
Outdated
| @@ -1,5 +1,5 @@ | |||
| <template> | |||
| <div v-bind="wrapperAttrs"> | |||
| <div v-on-click-outside="hideOptions" v-bind="wrapperAttrs"> | |||
There was a problem hiding this comment.
Maybe v-click-outside is better?
| /** | ||
| * Selected value. | ||
| */ | ||
| modelValue: { |
There was a problem hiding this comment.
Why modelValue have been removed?
| window.removeEventListener("pointerdown", onPointerdown, { passive: true }); | ||
| } | ||
|
|
||
| return removeEvents; |
There was a problem hiding this comment.
It's interesting to discuss how it works in depth
- Fixed issue with dropdown item click not being triggered
Explicit12
force-pushed
the
F1828_Fixed-issue-when-dropdown-item-click-wasnt-triggered_Dmytro_Holdobin
branch
from
c7ef452 to
d6604a8
Compare
itsJohnnyGrid
approved these changes
May 28, 2024
Explicit12
deleted the
F1828_Fixed-issue-when-dropdown-item-click-wasnt-triggered_Dmytro_Holdobin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ilevel.atlassian.net/jira/software/c/projects/FN/boards/2?selectedIssue=FN-1828