FN-1828_Remove-opacity-styles-from-button-component_Dmytro_Holdobin #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit12
force-pushed
the
FN-1828_Remove-opacity-styles-from-button-component_Dmytro_Holdobin
branch
from
6fcd0e1 to
939b3c7
Compare
Explicit12
commented
May 31, 2024
Explicit12
force-pushed
the
FN-1828_Remove-opacity-styles-from-button-component_Dmytro_Holdobin
branch
3 times, most recently
from
db15edd to
2712eda
Compare
itsJohnnyGrid
approved these changes
Jun 4, 2024
| @@ -121,7 +94,7 @@ export default /*tw*/ { | |||
| color: "white", | |||
| variant: "secondary", | |||
| class: ` | |||
| border-white bg-transparent text-white | |||
| border-white bg-transparent text-gray-500 | |||
There was a problem hiding this comment.
bg-transparen >>> bg-white
text-gray-500 >>> text-gray-900
hover / focus = text-gray-800
active = text-gray-700
There was a problem hiding this comment.
hover: text-gray-800 - need to be fixed and apply please those changes for all 3 variants of white button.
Explicit12
force-pushed
the
FN-1828_Remove-opacity-styles-from-button-component_Dmytro_Holdobin
branch
from
2712eda to
ca64121
Compare
Explicit12
force-pushed
the
FN-1828_Remove-opacity-styles-from-button-component_Dmytro_Holdobin
branch
from
ca64121 to
97e2286
Compare
itsJohnnyGrid
deleted the
FN-1828_Remove-opacity-styles-from-button-component_Dmytro_Holdobin
branch
| }, | ||
| { | ||
| color: "white", | ||
| variant: "thirdary", | ||
| class: ` | ||
| border-transparent bg-transparent text-white | ||
| border-transparent bg-transparent text-gray-500 |
There was a problem hiding this comment.
text-gray-900
active:text-gray-700
| @@ -121,16 +95,18 @@ export default /*tw*/ { | |||
| color: "white", | |||
| variant: "secondary", | |||
| class: ` | |||
| border-white bg-transparent text-white | |||
| border-white bg-white text-gray-900 | |||
| focus:border-white focus:ring-white | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.