This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
Use NODE_AUTH_TOKEN instead of old unmaintained npm-cli-login #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
commented
Apr 5, 2024
| run: | | ||
| npm install -g npm-cli-login | ||
| npm-cli-login -u "${{ secrets.NPM_USER }}" -p "${{ secrets.NPM_PASS }}" -e [email protected] -r https://registrynpm.storefrontcloud.io | ||
| registry-url: 'https://registrynpm.storefrontcloud.io' |
There was a problem hiding this comment.
the only problem here is that this needs a NODE_AUTH_TOKEN env var present like:
$ echo "NODE_AUTH_TOKEN=$(${{ secrets.NPM_USER }}:${{ secrets.NPM_PASS }} | base64)" >> $GITHUB_ENVI don't want to base64 the secrets because that way GitHub actions won't protect them against being leaked. It'd be much better to have a convention where you need to pass NODE_AUTH_TOKEN as a secret to this workflow.
The problem is that now we have a convention of having NPM_PASS and NPM_USER separately, so I'd need to write some compat input to the action that selectively uses one or the other.
Or just make a new branch for the newer CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.