fix: footer block semantic html structyre (#2994)

vuestorefront · Oct 2, 2023 · a9d3a52 · a9d3a52
1 parent 6b2d5c8
commit a9d3a52
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/apps/preview/next/pages/showcases/Footer/FooterBasic.tsx b/apps/preview/next/pages/showcases/Footer/FooterBasic.tsx
@@ -170,8 +170,8 @@ export default function FooterBasic() {
     <footer className="pt-10 bg-neutral-100">
       <div className="grid justify-center grid-cols-[1fr_1fr] md:grid-cols-[repeat(4,1fr)] px-4 md:px-6 pb-10 max-w-[1536px] mx-auto">
         {categories.map(({ label, subcategories }) => (
-          <div className="grid grid-cols xs:pb-4" key={label}>
-            <div className="ml-4 text-lg font-medium leading-7 text-neutral-900 font-body">{label}</div>
+          <ul className="grid grid-cols xs:pb-4" key={label}>
+            <li className="ml-4 text-lg font-medium leading-7 text-neutral-900 font-body">{label}</li>
             {subcategories?.map(({ subcategoryLabel, link }) => (
               <SfListItem className="py-2 !bg-transparent typography-text-sm font-body" key={subcategoryLabel}>
                 <SfLink
@@ -183,7 +183,7 @@ export default function FooterBasic() {
                 </SfLink>
               </SfListItem>
             ))}
-          </div>
+          </ul>
         ))}
       </div>
       <hr />

diff --git a/apps/preview/nuxt/pages/showcases/Footer/FooterBasic.vue b/apps/preview/nuxt/pages/showcases/Footer/FooterBasic.vue
@@ -3,8 +3,8 @@
     <div
       class="grid justify-center grid-cols-[1fr_1fr] md:grid-cols-[repeat(4,1fr)] px-4 md:px-6 pb-10 max-w-[1536px] mx-auto"
     >
-      <div v-for="{ label, subcategories } in categories" :key="label" class="grid grid-cols xs:pb-4">
-        <div class="ml-4 text-lg font-medium leading-7 text-neutral-900 font-body">{{ label }}</div>
+      <ul v-for="{ label, subcategories } in categories" :key="label" class="grid grid-cols xs:pb-4">
+        <li class="ml-4 text-lg font-medium leading-7 text-neutral-900 font-body">{{ label }}</li>
         <SfListItem
           v-for="{ subcategoryLabel, link } in subcategories"
           :key="subcategoryLabel"
@@ -18,7 +18,7 @@
             {{ subcategoryLabel }}
           </SfLink>
         </SfListItem>
-      </div>
+      </ul>
     </div>
     <hr />
     <div class="py-10 md:flex md:mx-auto max-w-[1536px]">