-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hero): backgroundImage should cover whole elements area on mobile [ES-387] #3089
fix(hero): backgroundImage should cover whole elements area on mobile [ES-387] #3089
Conversation
add description for best image sizes for hero background
|
suggested improvement: The Hero component simplifies the process of creating stunning hero sections for your website. With Hero, you have the flexibility to seamlessly integrate a main image and customize your content to suit your needs. Additionally, Hero offers optimized background images tailored for both mobile and desktop devices. To ensure an optimal blend of performance and visual appeal, we recommend adhering to the following image guidelines: Desktop Background Images: Mobile Background Images: |
Related issue
https://alokai.atlassian.net/browse/ES-387
Scope of work
current hero implementation is wrong for mobile devices - background image should try to cover whole element, but without changing it's aspect ratio
add description for best image sizes for hero background
Screenshots of visual changes
Hero on mobile before:
after:
Description:
Checklist