Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Added the countries.json file and updated the code to fetch the data from the file(#531) #532

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ymaheshwari1
Copy link
Contributor

Related Issues

#531

Closes #531

Short Description and Why It's Useful

This feature will help a user to define the specific countries for the storefront.

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

@ymaheshwari1
Copy link
Contributor Author

Another solution for implementing this functionality is to define the doingBusinessInCountry parameter in the config file consisting of the countries which we need to include in the storefront.
Then updating the code to filter the countries from the countries.json file on the basis of dbic field in the config.

@AishwaryShrivastav
Copy link
Contributor

@ymaheshwari1 @Fifciu , I think we can merge this implementation for now and can create an feature request for the DBIC implementation

Another solution for implementing this functionality is to define the doingBusinessInCountry parameter in the config file consisting of the countries which we need to include in the storefront.
Then updating the code to filter the countries from the countries.json file on the basis of dbic field in the config.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding DBIC feature in the theme
3 participants