Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logger #7238

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: logger #7238

wants to merge 3 commits into from

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Aug 22, 2024

closing https://alokai.atlassian.net/jira/polaris/projects/PROD/ideas/view/1113287?selectedIssue=PROD-91

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bartoszherba bartoszherba requested a review from a team as a code owner August 22, 2024 11:26
Copy link

changeset-bot bot commented Aug 22, 2024

πŸ¦‹ Changeset detected

Latest commit: 287f494

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@WojtekTheWebDev WojtekTheWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint can be ignored but we could start a discussion about the default factory result

.eslintrc.js Outdated
@@ -1,3 +1,6 @@
module.exports = {
extends: "@vue-storefront/eslint-config-integrations",
rules: {
"class-methods-use-this": "off",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good enough, but I think that we could add it to the @vue-storefront/eslint-config-integrations package directly


export class LoggerFactory {
static create(type: LoggerType, options: LoggerOptions = {}) {
switch (type) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we assume that we have an opinion about the default logger and use it if someone won't pass the type?

@bartoszherba bartoszherba force-pushed the feat/logger branch 2 times, most recently from cc7e10d to d36a288 Compare August 23, 2024 10:23
@bartoszherba bartoszherba force-pushed the feat/logger branch 2 times, most recently from bc2c84c to 7a494bd Compare October 3, 2024 09:08
bartoszherba and others added 2 commits October 3, 2024 11:18
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants