-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: logger #7238
base: main
Are you sure you want to change the base?
feat: logger #7238
Conversation
π¦ Changeset detectedLatest commit: 287f494 The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint can be ignored but we could start a discussion about the default factory result
.eslintrc.js
Outdated
@@ -1,3 +1,6 @@ | |||
module.exports = { | |||
extends: "@vue-storefront/eslint-config-integrations", | |||
rules: { | |||
"class-methods-use-this": "off", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good enough, but I think that we could add it to the @vue-storefront/eslint-config-integrations
package directly
|
||
export class LoggerFactory { | ||
static create(type: LoggerType, options: LoggerOptions = {}) { | ||
switch (type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we assume that we have an opinion about the default logger and use it if someone won't pass the type?
cc7e10d
to
d36a288
Compare
bc2c84c
to
7a494bd
Compare
7a494bd
to
1a51c51
Compare
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
closing https://alokai.atlassian.net/jira/polaris/projects/PROD/ideas/view/1113287?selectedIssue=PROD-91
π Linked issue
β Type of change
π Description
π Checklist