fix(DataTable): allow removal of additional sortings #20990
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20985
What I Did: The issue was with must-sort and multi-sort enabled, sorted columns couldn't be removed, only toggled ascending/descending. I modified toggleSort so in multi-sort mode, columns sorting descending are removed if multiple sorts are active, but toggle back to ascending if they're the only sorted column (satisfying must-sort).
How to Verify: Click a column header to sort ascending, then again for descending. Add another sorted column to test multi-sort - when you click the descending column, it should get removed since there's multiple sorts. Try with just one sorted column too - clicking it should just flip the sort direction instead of removing it.