-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notices for Budgeted and Actual Expenditure comparison #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add notice message when a department did not exist for one or more years.
* WIP on changing condition for notice from requiring only 1 missing phase to requiring all 4 phases to be missing
* Only raise program notice in correct cases
* Add test for budgeted and actual expenditure programme breakdown
* Re-add budgeted and actual summary
jbothma
reviewed
Jan 24, 2019
@@ -11,10 +11,15 @@ | |||
from budgetportal import models | |||
from django.test import TestCase | |||
from mock import Mock | |||
import json | |||
|
|||
with open('budgetportal/tests/test_data/budget_and_actual.json', 'r') as mock_data: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice - I've been thinking and googled a bit around conventions for this - did you just decide to do it this way or is this a convention you found somewherE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
cells
returned is higher than theset limit
(looks like a OpenSpending API bug, to be reported)Budgeted and Actual Expenditure comparison
summary sectionBudgeted and Actual Expenditure comparison
programme breakdown sectionNotices appear for the summary section when:
total
for a givenyear
is empty)-- E.g.
Please note that the data for 2014, 2013 and 2012 has not been published on vulekamali.
total
for a givenyear
is > 0, but no data for thisdept
in thisyear
)-- E.g.
This department did not exist for some years displayed.
A notice appears for the programme breakdown section when:
--
One or more programmes did not exist for some years displayed.
Notices are presented as a list of strings in the top level of the YAML output, e.g.:
📓 Notes: