fix expression #66
fix expression #66
Conversation
| // "signal input" --> Some(true) | ||
| // "signal output" --> Some(false) | ||
| // [N][M-1] | ||
| fn array(p: &mut Parser) -> bool { |
There was a problem hiding this comment.
So we should rename this to array_query?
There was a problem hiding this comment.
So we should rename this to array_query?
I don't understand the meaning of "array_query".
This function's use case is parsing [N][M-1] from a (multi-dimensional) array input[N][M-1].
| fn array(p: &mut Parser) -> bool { | ||
| let is_array = p.at(LBracket); | ||
|
|
||
| while p.at(LBracket) { |
There was a problem hiding this comment.
Why do we use why here?
For multi-dimensional array
|
|
||
| let res = if p.at(InputKw) { | ||
| Some(true) | ||
| } else if p.at(OutputKw) { |
There was a problem hiding this comment.
Why don't we use match?
You mean:
let result = match p.current() {
InputKw => Some(true),
OutputKw => Some(false),
_ => None
};
It is also another way (replace .at() with .current()). I will change it if you prefer.
| p.close(m, SignalHeader); | ||
| res | ||
| } | ||
|
|
||
| pub(crate) fn var_init(p: &mut Parser) { |
There was a problem hiding this comment.
Can you give example here?
// eg: tmp = 10;
|
|
||
| p.expect(RParen); | ||
|
|
||
| // p.close(m, ExpressionList); |
There was a problem hiding this comment.
So we don't create AST not for those function?
There was a problem hiding this comment.
So we don't create AST not for those function?
Can you explain your comment?
Update crates/lsp/src/global_state.rs Co-authored-by: Vu Vo <[email protected]>
NTTVy03
force-pushed
the
fix-expression
branch
from
c6dcb66 to
783f2a7
Compare
out[k] * (out[k] - 1) === 0