Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snapshot Lifecycle metrics #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashangit
Copy link

No description provided.

@lukas-vlcek
Copy link
Collaborator

Nicolas, do you think it would be possible to add some tests here?
https://github.com/vvanholl/elasticsearch-prometheus-exporter/tree/master/src/test/resources/rest-api-spec/test/resthandler

@ashangit
Copy link
Author

@lukas-vlcek I'm currently looking at adding some integration rest tests but to do so I need to rely on includeXpack '*' on restResources of the gradle.build
But it seems that usage of includeXpack is forbidden outside of the elasticsearch build: https://github.com/elastic/elasticsearch/blob/6f02a9b0889d8dc57707842d85629b0a71b6b8d3/buildSrc/src/main/java/org/elasticsearch/gradle/test/rest/RestResourcesExtension.java#L63
This check rely on the capability of loading /buildSrc.marker from the classpath in https://github.com/elastic/elasticsearch/blob/6f02a9b0889d8dc57707842d85629b0a71b6b8d3/buildSrc/src/main/java/org/elasticsearch/gradle/info/GlobalBuildInfoPlugin.java#L95
I can try to find a way to have this marker file available so we can load those Xpack in the ES test clusters but I'm wondering if it is appropriate to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants