Metrics that call seconds()/getSeconds() round values to integers #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvanholl
force-pushed
the
master
branch
12 times, most recently
from
9c3829c
to
daa4dbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some of _time_seconds metrics use second-level precision.
For example, the
rate(es_jvm_gc_collection_time_seconds[..])suffers from low accuracy:I would like to suggest the following small change. It helps us to better monitor ES performance.
If I understand correctly, there no difference between millis() and getMillis():
So, I just renamed seconds()/getSeconds() in the same way