Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcast-relay: T5313: verify() relay interfaces have IPv4 address configured #2057

Merged
merged 2 commits into from
Jun 30, 2023
Merged

bcast-relay: T5313: verify() relay interfaces have IPv4 address configured #2057

merged 2 commits into from
Jun 30, 2023

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 25, 2023

Change Summary

(cherry picked from commit ca7c063)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

UDP broadcast relay

Proposed changes

How to test

Smoketests or

set service broadcast-relay id 1 description 'SONOS'
set service broadcast-relay id 1 interface 'eth3'
set service broadcast-relay id 1 interface 'eth4'
set service broadcast-relay id 1 interface 'eth5'
set service broadcast-relay id 1 port '1900'

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team June 25, 2023 18:27
dmbaturin
dmbaturin approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is fine of course, I only think that messages can be improved.

src/conf_mode/bcast_relay.py Outdated Show resolved Hide resolved
src/conf_mode/bcast_relay.py Outdated Show resolved Hide resolved
@c-po c-po merged commit 64cc7d7 into vyos:equuleus Jun 30, 2023
@c-po c-po deleted the t5313-backport branch August 5, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jestabro jestabro jestabro approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever was automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @dmbaturin @jestabro