Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vrrp: T5315: add support to explicitly specify version (backport) #2058

Merged
merged 2 commits into from
Jun 27, 2023
Merged

vrrp: T5315: add support to explicitly specify version (backport) #2058

merged 2 commits into from
Jun 27, 2023

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 26, 2023

Change Summary

(cherry picked from commit 6ca3081)
(cherry picked from commit 90c0c2c)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

VRRP, keepalived

Proposed changes

set high-availability vrrp global-parameters version 2|3

How to test

Smoketests

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

c-po added 2 commits June 26, 2023 21:32
@c-po
vrrp: T5315: add support to explicitly specify version
463a207 
set high-availability vrrp group <name> version 2|3

(cherry picked from commit 6ca3081)
@c-po
vrrp: T5315: fix completion helper
e8ab66d 
(cherry picked from commit 90c0c2c)
@vyosbot vyosbot requested review from a team and removed request for a team June 26, 2023 19:51
@c-po c-po merged commit 6efdecd into vyos:equuleus Jun 27, 2023
@c-po c-po deleted the vrrp-t5315-backport branch August 5, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@jestabro jestabro jestabro approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @jestabro @sever-sever