Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPP: T1797: Added interfaces reinitialization #2071

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

zdc
Copy link
Contributor

@zdc zdc commented Jul 3, 2023

Change Summary

Added interfaces reinitialization for VPP

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

VPP

Proposed changes

After an interface is added/removed from VPP, it will be reinitialized, which allows reconfiguring IP addresses on it.

Also modified VPP load priority to start before interfaces, and avoid reconfiguration during boot.

How to test

Add/delete interfaces to VPP. During this process they are destroyed and created again in the system, therefore config is always empty. With this change, they will be reinitialized according to CLI configuration:

set interfaces ethernet eth0 address '192.0.2.1/24'
set vpp interface eth0
commit
set interfaces ethernet eth0 address '192.0.2.1/24'
delete vpp interface eth0
commit
vyos@vyos# run show interfaces 
Codes: S - State, L - Link, u - Up, D - Down, A - Admin Down
Interface        IP Address                        S/L  Description
---------        ----------                        ---  -----------
eth0             192.0.2.1/24                      u/u  
lo               127.0.0.1/8                       u/u  
                 ::1/128                                

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

After an interface is added/removed from VPP, it will be reinitialized, which
allows reconfiguring IP addresses on it.

Also modified VPP load priority to start before interfaces, and avoid
reconfiguration during boot.
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, jestabro, sever-sever and c-po and removed request for a team July 3, 2023 15:35
@c-po c-po merged commit b9e0cbf into vyos:current Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants