Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5336: Add Swedish keyboard-layout #2075

Merged
merged 1 commit into from
Jul 5, 2023
Merged

T5336: Add Swedish keyboard-layout #2075

merged 1 commit into from
Jul 5, 2023

Conversation

Apachez-
Copy link
Contributor

@Apachez- Apachez- commented Jul 5, 2023

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

set system option keyboard-layout

Proposed changes

Adding swedish keymap as system option keyboard-layout

How to test

Switched between keymaps using "set system option keyboard-layout" and verified through console that se-latin1 is fully functional using a swedish keyboard.

Note that this is only valid when connected through local console. Connecting through SSH is usually a workaround for this issue.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team July 5, 2023 14:35
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but I wonder: can we list all layouts available in the system programmatically somehow? Are there reasons not to expose them all, or it hard to do?

@c-po
Copy link
Member

c-po commented Jul 5, 2023

This works, but I wonder: can we list all layouts available in the system programmatically somehow? Are there reasons not to expose them all, or it hard to do?

I think that is a much better approach then we currently have

@c-po c-po merged commit 8afdb5a into vyos:current Jul 5, 2023
2 checks passed
@Apachez-
Copy link
Contributor Author

Apachez- commented Jul 5, 2023

This works, but I wonder: can we list all layouts available in the system programmatically somehow? Are there reasons not to expose them all, or it hard to do?

That would be prefered but there are ALOT of them in /usr/share/keymaps/i386/ so tab completing all of them in configuration mode would be hilarious.

One way might be to add the most popular languages along with a final option named "custom" or similar where one then can define whatever one like from the /usr/share/keymaps/i386/ directories.

@dmbaturin
Copy link
Member

I think a custom layout option is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants