Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T775: Config-sync bracketize IPv6 secondary address #2082

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

sever-sever
Copy link
Member

Change Summary

bracketize IPv6 remote address to avoid Failed to parse: https://2001:db8::2/configure-section

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

config-sync

Proposed changes

How to test

VyOS configuration:

set service config-sync mode 'load'
set service config-sync secondary address '2001:db8::2'
set service config-sync secondary key 'foo'
set service config-sync section 'nat'
set service config-sync section 'firewall'

set nat source rule 100 description '222'
set nat source rule 100 outbound-interface 'eth0'
set nat source rule 100 source address '192.0.2.0/24'
set nat source rule 100 translation address 'masquerade'

Commit before the fix:

vyos@r14# commit
INFO:vyos_config_sync:Config synchronization: Mode=load, Secondary=2001:db8::2
An error occurred: Failed to parse: https://2001:db8::2/configure-section
ERROR:vyos_config_sync:An error occurred: Failed to parse: https://2001:db8::2/configure-section
An error occurred: Failed to parse: https://2001:db8::2/configure-section
ERROR:vyos_config_sync:An error occurred: Failed to parse: https://2001:db8::2/configure-section
[edit]
vyos@r14# 

Commit after the fix:

vyos@r14# commit
[ nat ]

INFO:vyos_config_sync:Config synchronization: Mode=load, Secondary=[2001:db8::2]
[edit]
vyos@r14# 

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

bracketize IPv6 remote address to avoid
Failed to parse: https://2001:db8::2/configure-section
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for a team July 9, 2023 15:59
@c-po c-po merged commit c171673 into vyos:current Jul 9, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants