Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5446: BGP: change <bgp paramater bestpath med> from node to leafNode #2137

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

nicolas-fort
Copy link
Contributor

Change Summary

Change set protocols bgp paramater bestpath med from node to leafNode, in order to avoid empty value and problems when removing such parameters

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

bgp

Proposed changes

How to test

vyos@LEFT# run show config comm | grep bgp
set protocols bgp address-family ipv4-unicast network 192.0.2.0/24
set protocols bgp neighbor 198.51.100.2 address-family ipv4-unicast soft-reconfiguration inbound
set protocols bgp neighbor 198.51.100.2 remote-as 'external'
set protocols bgp neighbor 198.51.100.2 update-source '198.51.100.1'
set protocols bgp parameters bestpath med 'missing-as-worst'
set protocols bgp parameters bestpath med 'confed'
set protocols bgp parameters router-id '198.51.100.1'
set protocols bgp system-as '65545'
[edit]
vyos@LEFT# sudo vtysh -c "show run" | grep med
 bgp bestpath med confed missing-as-worst
[edit]
vyos@LEFT# del protocols bgp parameters bestpath med confed 
[edit]
vyos@LEFT# commit
[edit]
vyos@LEFT# sudo vtysh -c "show run" | grep med
 bgp bestpath med missing-as-worst
[edit]
vyos@LEFT# del protocols bgp parameters bestpath med 
[edit]
vyos@LEFT# compare
[protocols bgp parameters bestpath]
- med "missing-as-worst"

[edit]
vyos@LEFT# commit
[edit]
vyos@LEFT# sudo vtysh -c "show run" | grep med
[edit]
vyos@LEFT# run show config comm | grep bgp
set protocols bgp address-family ipv4-unicast network 192.0.2.0/24
set protocols bgp neighbor 198.51.100.2 address-family ipv4-unicast soft-reconfiguration inbound
set protocols bgp neighbor 198.51.100.2 remote-as 'external'
set protocols bgp neighbor 198.51.100.2 update-source '198.51.100.1'
set protocols bgp parameters bestpath
set protocols bgp parameters router-id '198.51.100.1'
set protocols bgp system-as '65545'
[edit]
vyos@LEFT# 

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

…, in order to avoid empty value and problems when removing such parameters
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team August 7, 2023 17:06
@c-po c-po merged commit 91144f2 into vyos:current Aug 7, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants