Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5489: Change default qdisc from 'fq' to 'fq_codel' #2349

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

Apachez-
Copy link
Contributor

@Apachez- Apachez- commented Oct 8, 2023

Change Summary

Default qdisc should be "fq_codel" rather than "fq" with "bbr" as congestion control in modern Linux kernels.

This is a followup on #2224

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

sysctl

Proposed changes

Change following parameters in src/etc/sysctl.d/30-vyos-router.conf from:

net.core.default_qdisc=fq
net.ipv4.tcp_congestion_control=bbr

to:

net.core.default_qdisc=fq_codel
net.ipv4.tcp_congestion_control=bbr

Ref:

https://www.bufferbloat.net/projects/codel/wiki/

Either qdisc can be enabled by default via a single sysctl option in /etc/sysctl.conf:

net.core.default_qdisc = fq_codel - best general purpose qdisc

net.core.default_qdisc = fq - for fat servers, fq_codel for routers.

Also thread in https://forum.vyos.io/t/bbr-and-fq-as-new-defaults/12344/10

How to test

After install/upgrade verify default settings through:

# sudo cat /etc/sysctl.d/30-vyos-router.conf
...
# Congestion control
net.core.default_qdisc=fq_codel
net.ipv4.tcp_congestion_control=bbr

or:

vyos@vyos:~$ sudo sysctl -a | grep net.core.default_qdisc
net.core.default_qdisc = fq_codel

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team October 8, 2023 17:43
@c-po c-po merged commit 1280734 into vyos:current Oct 8, 2023
7 of 8 checks passed
@c-po
Copy link
Member

c-po commented Oct 8, 2023

@Mergifyio backport sagitta

@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2023

backport sagitta

✅ Backports have been created

@Apachez- Apachez- deleted the T5489 branch October 8, 2023 18:03
c-po added a commit that referenced this pull request Oct 13, 2023
T5489: Change default qdisc from 'fq' to 'fq_codel' (backport #2349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants