Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snmp: T5855: migrate "set service lldp snmp enable" to "set service lldp snmp" #2687

Merged
merged 2 commits into from
Dec 25, 2023
Merged

snmp: T5855: migrate "set service lldp snmp enable" to "set service lldp snmp" #2687

merged 2 commits into from
Dec 25, 2023

Conversation

c-po
Copy link
Member

@c-po c-po commented Dec 25, 2023

Change Summary

Remove "enable" subnode under "lldp snmp" configuration

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): CLI de-cluttering

Related Task(s)

Related PR(s)

Component(s) name

LLDP and SNMP

Proposed changes

How to test

Smoketest result

[email protected]:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_lldp.py
test_01_lldp_basic (__main__.TestServiceLLDP.test_01_lldp_basic) ... ok
test_02_lldp_mgmt_address (__main__.TestServiceLLDP.test_02_lldp_mgmt_address) ... ok
test_03_lldp_interfaces (__main__.TestServiceLLDP.test_03_lldp_interfaces) ... ok
test_04_lldp_all_interfaces (__main__.TestServiceLLDP.test_04_lldp_all_interfaces) ... ok
test_05_lldp_location (__main__.TestServiceLLDP.test_05_lldp_location) ... ok
test_06_lldp_snmp (__main__.TestServiceLLDP.test_06_lldp_snmp) ... ok

----------------------------------------------------------------------
Ran 6 tests in 27.858s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po mentioned this pull request Dec 25, 2023
Merged
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team December 25, 2023 08:15
@c-po c-po merged commit 4cf15bd into vyos:current Dec 25, 2023
7 checks passed
@c-po
Copy link
Member Author

c-po commented Dec 25, 2023

@Mergifyio backport sagitta

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2023 •
edited
Loading

backport sagitta

✅ Backports have been created

@mergify mergify bot mentioned this pull request Dec 25, 2023
Merged
c-po added a commit that referenced this pull request Dec 25, 2023
@c-po
Merge pull request #2688 from vyos/mergify/bp/sagitta/pr-2687
7f16fff 
snmp: T5855: migrate "set service lldp snmp enable" to "set service lldp snmp" (backport #2687)
@c-po c-po deleted the lldp-snmp-t5855 branch January 11, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-po @sever-sever