Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6354: Get rid of the custom boot type check in version.py #3474

Merged
merged 1 commit into from
May 17, 2024

Conversation

HollyGurza
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

vyos@vyos:~$ show version 
Version:          VyOS 1.5-rolling-202405080016
Release train:    current

Built by:         [email protected]
Built on:         Wed 08 May 2024 02:49 UTC
Build UUID:       c2dc10d6-bfe8-4443-8e86-b32ff261a25d
Build commit ID:  bdde6daecd46f3

Architecture:     x86_64
Boot via:         installed image
System type:      KVM guest

Hardware vendor:  QEMU
Hardware model:   Standard PC (i440FX + PIIX, 1996)
Hardware S/N:     
Hardware UUID:    a265716d-3af6-452f-bc42-a9448452fb54

Copyright:        VyOS maintainers and contributors

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po merged commit d1b6b40 into vyos:current May 17, 2024
7 of 8 checks passed
@c-po
Copy link
Member

c-po commented May 17, 2024

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented May 17, 2024

backport sagitta

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants