-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dhclient: T6667: Added workaround for communication with FRR #4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdc
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever,
fett0 and
nicolas-fort
August 21, 2024 19:08
👍 |
✅ No issues found in unused-imports check.. Please refer the workflow run |
dmbaturin
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think log message wording can be improved, though.
To increase the chance for dhclient to configure routes in FRR, added a workaround. Now 10 attempts are performed with 1 second delay and only after this dhclient gives up.
sever-sever
approved these changes
Aug 22, 2024
dmbaturin
approved these changes
Aug 24, 2024
@Mergifyio backport sagitta |
✅ Backports have been created
|
@Mergifyio backport circinus |
✅ Backports have been created
|
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added workaround for communication with FRR
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
dhclient
Proposed changes
To increase the chance for dhclient to configure routes in FRR, added a workaround. Now 10 attempts are performed with 1 second delay and only after this dhclient gives up.
How to test
Unfortunately, the issue is hard to catch, using VyOS config scripts only, without explicitly forcing it.
More details about reproducing are in: https://vyos.dev/T6667
Smoketest result
N/A
Checklist: