Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhclient: T6667: Added workaround for communication with FRR #4002

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

zdc
Copy link
Contributor

@zdc zdc commented Aug 21, 2024

Change Summary

Added workaround for communication with FRR

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

dhclient

Proposed changes

To increase the chance for dhclient to configure routes in FRR, added a workaround. Now 10 attempts are performed with 1 second delay and only after this dhclient gives up.

How to test

Unfortunately, the issue is hard to catch, using VyOS config scripts only, without explicitly forcing it.
More details about reproducing are in: https://vyos.dev/T6667

Smoketest result

N/A

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Aug 21, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Aug 21, 2024

✅ No issues found in unused-imports check.. Please refer the workflow run

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think log message wording can be improved, though.

src/etc/dhcp/dhclient-enter-hooks.d/03-vyos-ipwrapper Outdated Show resolved Hide resolved
src/etc/dhcp/dhclient-enter-hooks.d/03-vyos-ipwrapper Outdated Show resolved Hide resolved
To increase the chance for dhclient to configure routes in FRR, added a
workaround. Now 10 attempts are performed with 1 second delay and only after
this dhclient gives up.
@sever-sever sever-sever enabled auto-merge (squash) August 22, 2024 11:12
@sever-sever sever-sever enabled auto-merge (rebase) August 22, 2024 11:47
@sever-sever sever-sever merged commit da64a72 into vyos:current Aug 24, 2024
13 of 14 checks passed
@zdc
Copy link
Contributor Author

zdc commented Sep 26, 2024

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Sep 26, 2024

backport sagitta

✅ Backports have been created

@zdc
Copy link
Contributor Author

zdc commented Sep 26, 2024

@Mergifyio backport circinus

Copy link
Contributor

mergify bot commented Sep 26, 2024

backport circinus

✅ Backports have been created

c-po added a commit that referenced this pull request Sep 30, 2024
dhclient: T6667: Added workaround for communication with FRR (backport #4002)
dmbaturin added a commit that referenced this pull request Sep 30, 2024
dhclient: T6667: Added workaround for communication with FRR (backport #4002)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants