Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

op-mode: T6715: manually changing time/date is not synced into hardware clock (backport #4071) #4074

Merged
merged 1 commit into from
Sep 16, 2024
Merged

op-mode: T6715: manually changing time/date is not synced into hardware clock (backport #4071) #4074

merged 1 commit into from
Sep 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 16, 2024

Change Summary

When not using NTP and adjusting the current system time/date using set date the time is not saved across a reboot into the hardware RTC. This commit explicitly syncs the current time after a change into the systems RTC.

Most routers do not run without NTP (which is even a VyOS default) so the priority is pretty low.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

How to test

set date 0916140224

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
This is an automatic backport of pull request #4071 done by [Mergify](https://mergify.com).

@c-po @mergify
op-mode: T6715: manually changing time/date is not synced into hardwa…
51e38f8 
…re clock

When not using NTP and adjusting the current system time/date using set date
the time is not saved across a reboot into the hardware RTC. This commit
explicitly syncs the current time after a change into the systems RTC.

Most routers do not run without NTP (which is even a VyOS default) so the
priority is pretty low.

(cherry picked from commit 835126e)
@mergify mergify bot requested a review from a team as a code owner September 16, 2024 09:40
@mergify mergify bot mentioned this pull request Sep 16, 2024
Merged
12 tasks
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Sep 16, 2024
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@sever-sever sever-sever merged commit 7a71f27 into sagitta Sep 16, 2024
9 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-4071 branch September 16, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@sarthurdev sarthurdev sarthurdev approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@c-po c-po Awaiting requested review from c-po c-po is a code owner automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 is a code owner automatically assigned from vyos/reviewers

Assignees
No one assigned
Labels
sagitta VyOS 1.4 LTS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmbaturin @sarthurdev @sever-sever @c-po