T6716: don't automatically set ethernet offload (backport #4077) #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Remove the lines of code that checked if the kernel had offloading enabled and was then forcing the config to set it to "on." The behavior now mirrors the config and offloading will only be enabled if the config is explicitly set to enabled. Note: the code is still present to disable the offloading, in the config, if the kernel doesn't support it. Note(2): Allow the previous behavior where the offload settings get set, based on the Kernel, if the boot is a live boot. (cherry picked from commit b6c2a74)
mergify
bot
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
c-po and
nicolas-fort
and removed request for
a team
12 tasks
|
👍 |
jestabro
approved these changes
Sep 17, 2024
sever-sever
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove the lines of code that checked if the kernel had offloading enabled and was then forcing the config to set it to "on." The behavior now mirrors the config and offloading will only be enabled if the config is explicitly set to enabled.
Note: the code is still present to disable the offloading, in the config, if the kernel doesn't support it.
Types of changes
Related Task(s)
https://vyos.dev/T6716
Related PR(s)
Component(s) name
Ethernet activation script (20-ethernet_offload.py)
Proposed changes
Delete lines of code that set the ethernet offload setting based on the Kernel offload setting.
How to test
On a system where the kernel enables offloading at boot and/or the offload is currently set in the config:
No offloading settings should be shown. On VyOS 1.5, without this PR, the offload settings will automatically be restored.
Smoketest result
Checklist:
This is an automatic backport of pull request #4077 done by [Mergify](https://mergify.com).