Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6486: use data-ciphers instead of ncp-ciphers in "run generate openvpn client-config" (backport #3930) #4081

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 18, 2024

Change Summary

In the PR #3823 the ncp-ciphers were replaced with data-ciphers
fix the template for generate openvpn client-config

Backport is not required until #3823 is not backported.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

openvpn

Proposed changes

How to test

VyOS configuration:

set interfaces openvpn vtun20 encryption data-ciphers 'aes256'
set interfaces openvpn vtun20 hash 'sha512'
set interfaces openvpn vtun20 local-host '203.0.113.1'
set interfaces openvpn vtun20 mode 'server'
set interfaces openvpn vtun20 openvpn-option 'push keepalive 1 10'
set interfaces openvpn vtun20 protocol 'tcp-passive'
set interfaces openvpn vtun20 server client foo ip '100.64.0.2'
set interfaces openvpn vtun20 server subnet '10.0.22.0/24'
set interfaces openvpn vtun20 server topology 'subnet'
set interfaces openvpn vtun20 tls ca-certificate 'ca'
set interfaces openvpn vtun20 tls certificate 'cert'
set interfaces openvpn vtun20 tls dh-params 'dh'

Generate OpenVPN client config
Check cipher AES-256-CBC

vyos@r4:~$ generate openvpn client-config interface vtun20 ca ca certificate openvpn-client 

client
nobind
remote 203.0.113.1 1194
remote-cert-tls server
proto tcp-client
dev tun
dev-type tun
persist-key
persist-tun
verb 3

# Encryption options
cipher AES-256-CBC
data-ciphers AES-256-CBC
auth sha512

<ca>
xxx
</ca>

<cert>
xxx
</cert>

<key>
xxx
</key>

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3930 done by [Mergify](https://mergify.com).

In the PR #3823 the ncp-ciphers
were replaced with `data-ciphers`
fix template for "generate openvpn client-config"

(cherry picked from commit ffbc04c)
Copy link

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin merged commit 19ac59d into circinus Sep 18, 2024
9 checks passed
@mergify mergify bot deleted the mergify/bp/circinus/pr-3930 branch September 18, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants