Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T6496: Added support for WPA-Enterprise client-mode (backport #3711) #4085

Merged
merged 3 commits into from
Sep 19, 2024
Merged

T6496: Added support for WPA-Enterprise client-mode (backport #3711) #4085

merged 3 commits into from
Sep 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 19, 2024

Change Summary

Added support for WPA-Enterprise client-mode

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

wireless

Proposed changes

How to test

Configuration:

vyos@vyos# edit interfaces wireless wlan0
set security wpa enterprise_username 'somedomain\someuser'
set security wpa enterprise_passphrase 'somepassphrase'
vyos@vyos#

show interface wireless output:

vyos@vyos:~$ show interfaces wireless
Codes: S - State, L - Link, u - Up, D - Down, A - Admin Down
Interface        IP Address                        S/L  Description
---------        ----------                        ---  -----------
wlan0            -                                 A/D  SWC-24
wlan1            10.1.0.1/24                       A/D  Test AP (2.4Ghz)
wlan2            10.6.32.101/20                     u/u  SWC-5
vyos@vyos:~$

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation --> it doesn't seem like the docs for wireless security document everything so I'm going to take that approach.
  • I have updated the documentation accordingly
This is an automatic backport of pull request #3711 done by [Mergify](https://mergify.com).

part1cleth1ef and others added 3 commits September 19, 2024 07:00
@part1cleth1ef @mergify
wireless: T6496: support for EAP-MSCHAPv2 client over wifi
d505264 
fix: attempt to fix indentation on `wpa_supplicant.conf.j2`

fix: attempt to fix indentation on `wpa_supplicant.conf.j2`

fix: incorrect bssid mapping

fix: use the correct jinja templating (I think)

fix: “remote blank space

fix: attempt to fix the formatting in j2

fix: attempt to fix the formatting in j2

feat: rename enterprise username and password + add checks in conf mode.

fix: move around `bssid` config option on `wpa_supplicant.conf.j2` and fix the security config part

fix: fix indentation on `wpa_supplicant.conf.j2`
(cherry picked from commit fc42630)
@c-po @mergify
wireless: T6496: use ascii regex for WPA passphrase constraint
c8f116c 
(cherry picked from commit 5a6ac65)
@c-po @mergify
wireless: T6496: use mac-address validator on BSSID and move it up on…
b76a5c9 
…e CLI level

(cherry picked from commit 0c9499c)
@mergify mergify bot requested a review from a team as a code owner September 19, 2024 07:00
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, sever-sever and nicolas-fort and removed request for a team September 19, 2024 07:00
@mergify mergify bot mentioned this pull request Sep 19, 2024
Merged
12 tasks
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin merged commit 1909f2d into circinus Sep 19, 2024
9 checks passed
@sever-sever sever-sever deleted the mergify/bp/circinus/pr-3711 branch October 17, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort is a code owner automatically assigned from vyos/reviewers

Assignees
No one assigned
Labels
circinus
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmbaturin @sever-sever @part1cleth1ef @c-po