Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lldp: T6727: add missing input validation for interface names #4091

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Sep 20, 2024

Change Summary

There is no input CLI validation on the interface name passed to the LLDP service.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

lldp

Smoketest result

vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_lldp.py
test_01_lldp_basic (__main__.TestServiceLLDP.test_01_lldp_basic) ... ok
test_02_lldp_mgmt_address (__main__.TestServiceLLDP.test_02_lldp_mgmt_address) ... ok
test_03_lldp_interfaces (__main__.TestServiceLLDP.test_03_lldp_interfaces) ... ok
test_04_lldp_all_interfaces (__main__.TestServiceLLDP.test_04_lldp_all_interfaces) ... ok
test_05_lldp_location (__main__.TestServiceLLDP.test_05_lldp_location) ... ok
test_06_lldp_snmp (__main__.TestServiceLLDP.test_06_lldp_snmp) ... ok

----------------------------------------------------------------------
Ran 6 tests in 14.461s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
Copy link
Member Author

c-po commented Sep 20, 2024

@Mergifyio backport sagitta circinus

@c-po c-po enabled auto-merge September 20, 2024 20:40
Copy link

github-actions bot commented Sep 20, 2024

👍
No issues in PR Title / Commit Title

Copy link

mergify bot commented Sep 20, 2024

backport sagitta circinus

✅ Backports have been created

There is no input CLI validation on the interface name passed to the LLDP
service.
@c-po c-po merged commit 3e884c5 into vyos:current Sep 21, 2024
16 of 17 checks passed
c-po added a commit that referenced this pull request Sep 22, 2024
lldp: T6727: add missing input validation for interface names (backport #4091)
c-po added a commit that referenced this pull request Sep 23, 2024
lldp: T6727: add missing input validation for interface names (backport #4091)
@c-po c-po deleted the lldp-t6727 branch September 30, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants