Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslog: T6719: fix the behavior of "syslog global preserve-fqdn" (backport #4079) #4097

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 24, 2024

Change Summary

Add config option to set local host name for syslog

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

system

How to test

set system domain-name example.local
set system syslog global preserve-fqdn

Adds the rsyslog config entry

$LocalHostName vyos.example.local

Smoketest result

vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_system_syslog.py
test_syslog_basic (__main__.TestRSYSLOGService.test_syslog_basic) ... ok
test_syslog_global (__main__.TestRSYSLOGService.test_syslog_global) ... ok

----------------------------------------------------------------------
Ran 2 tests in 21.041s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #4079 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner September 24, 2024 16:32
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, c-po and nicolas-fort and removed request for a team September 24, 2024 16:32
Copy link

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin merged commit 2981156 into circinus Sep 25, 2024
9 checks passed
@sever-sever sever-sever deleted the mergify/bp/circinus/pr-4079 branch October 17, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants