Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validators: T6739: fix ipaddrcheck argument quoting (backport #4099) #4100

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 26, 2024

Change Summary

Properly quote ipaddrcheck arguments in validator scripts to ensure they are handled correctly if they contain whitespace. Right now such arguments are correctly rejected but result in confusing error messages that contain ipaddrcheck's help:

vyos@vyos# set interfaces ethernet eth1 address "a valid IP address, I swear!"

  Error: wrong number of arguments, one argument required!
  Usage: ipaddrcheck <OPTIONS> [STRING]
  Address checking options:
    --is-valid                 Check if STRING is a valid IPv4 or IPv6 address
                                 with or without prefix length
    --is-any-cidr              Check if STRING is a valid IPv4 or IPv6 address
                                 with prefix length

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Component(s) name

Validators.

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #4099 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner September 26, 2024 04:56
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, sever-sever and nicolas-fort and removed request for a team September 26, 2024 04:56
Copy link

👍
No issues in PR Title / Commit Title

@c-po
Copy link
Member

c-po commented Sep 26, 2024

@c-po c-po closed this Sep 26, 2024
@sever-sever sever-sever deleted the mergify/bp/circinus/pr-4099 branch October 17, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants