http-api: T6736: move REST API to a node distinct from GraphQL API

[jestabro]

Change Summary

The REST API was originally implemented under the node ['service', 'https', 'api'], and the GraphQL API implemented as a subnode of that path. Refactor the http-api server into distinct configuration nodes:

['service', 'https', 'api', 'rest']
['service', 'https', 'api', 'graphql']

Structures shared by the apis are simplified; distinct structures are organized more symmetrically.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

• New feature (non-breaking change which adds functionality)

• Code style update (formatting, renaming)

• Refactoring (no functional changes)
  --- the one functional change is that the GraphQL API may now be made available independently of the REST API.

• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component

• Other (please describe):

Related Task(s)

Related PR(s)

vyos/vyos-documentation#1557

Component(s) name

Proposed changes

How to test

Smoketest result

DEBUG - Running Testcase: /usr/libexec/vyos/tests/smoke/cli/test_service_https.py
DEBUG - test_api_add_delete (__main__.TestHTTPSService.test_api_add_delete) ... ok
DEBUG - test_api_auth (__main__.TestHTTPSService.test_api_auth) ... ok
DEBUG - test_api_config_file (__main__.TestHTTPSService.test_api_config_file) ... ok
DEBUG - test_api_config_file_load_http (__main__.TestHTTPSService.test_api_config_file_load_http) ... ok
DEBUG - test_api_configure (__main__.TestHTTPSService.test_api_configure) ... ok
DEBUG - test_api_generate (__main__.TestHTTPSService.test_api_generate) ... ok
DEBUG - test_api_image (__main__.TestHTTPSService.test_api_image) ... ok
DEBUG - test_api_incomplete_key (__main__.TestHTTPSService.test_api_incomplete_key) ... ok
DEBUG - test_api_missing_keys (__main__.TestHTTPSService.test_api_missing_keys) ... ok
DEBUG - test_api_reset (__main__.TestHTTPSService.test_api_reset) ... ok
DEBUG - test_api_show (__main__.TestHTTPSService.test_api_show) ... ok
DEBUG - test_certificate (__main__.TestHTTPSService.test_certificate) ... ok
DEBUG -
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 12 tests in 70.122s
DEBUG -
DEBUG - OK

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[github-actions]

✅ No issues found in unused-imports check.. Please refer the workflow run

[jestabro]

The only remaining linting errors are due to an attempt to apply ruff to a now deleted file (since listed as a 'changed' file). Need to use added|modified in filter here:
https://github.com/vyos/.github/blob/current/.github/workflows/lint-with-ruff.yml#L28

[jestabro]

Comments as to why the CodeQL scans are now dismissed are under 'Show dismissed'/'Show more details', namely:

1. The stack trace does not expose any structure that is not already apparent by inspection of the open source code repository.
2. The code scan is missing the fact that the return value is now sanitized by html.escape().

[jestabro]

Linting error fixed with:
vyos/.github#49

[github-actions]

CI integration ❌ failed!

Details

CI logs

• CLI Smoketests ❌ failed
• Config tests 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed