Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syslog: T5367: add format option to include timezone in message (backport #4061) #4115

Merged
merged 1 commit into from
Sep 30, 2024
Merged

syslog: T5367: add format option to include timezone in message (backport #4061) #4115

merged 1 commit into from
Sep 30, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 30, 2024

Change Summary

Add CLI option to include the systems timezone in the syslog message sent to a collector.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

syslog

How to test

set system syslog host <hostname> format include-timezone

Smoketest result

[email protected]:~$ /usr/libexec/vyos/tests/smoke/cli/test_system_syslog.py
test_syslog_basic (__main__.TestRSYSLOGService.test_syslog_basic) ... ok

----------------------------------------------------------------------
Ran 1 test in 3.977s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
This is an automatic backport of pull request #4061 done by [Mergify](https://mergify.com).

@c-po @mergify
syslog: T5367: add format option to include timezone in message
9a7d920 
Add CLI option to include the systems timezone in the syslog message sent to
a collector. This can be enabled using:

  set system syslog host <hostname> format include-timezone

(cherry picked from commit 042be39)
@mergify mergify bot requested a review from a team as a code owner September 30, 2024 14:58
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, c-po and fett0 and removed request for a team September 30, 2024 14:58
@mergify mergify bot mentioned this pull request Sep 30, 2024
Merged
12 tasks
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin merged commit b191ea3 into circinus Sep 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin approved these changes

@c-po c-po c-po approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 is a code owner automatically assigned from vyos/reviewers

Assignees
No one assigned
Labels
circinus
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmbaturin @c-po