Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T3501: Allow using more than one tuned profile #4179

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

natali-rs1985
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

system option

Proposed changes

Added new TuneD profiles and ability to activate several profiles

How to test

set system option performance 'network-latency'
set system option performance 'powersave'
commit

vyos@vyos# tuned-adm active
Current active profile: network-latency powersave

Smoketest result

vyos@vyos# python3 /usr/libexec/vyos/tests/smoke/cli/test_system_option.py
test_ctrl_alt_delete (__main__.TestSystemOption.test_ctrl_alt_delete) ... ok
test_performance (__main__.TestSystemOption.test_performance) ... ok
test_reboot_on_panic (__main__.TestSystemOption.test_reboot_on_panic) ... ok
test_ssh_client_options (__main__.TestSystemOption.test_ssh_client_options) ... ok

----------------------------------------------------------------------
Ran 4 tests in 31.416s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Oct 28, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Oct 28, 2024

✅ No issues found in unused-imports check.. Please refer the workflow run

smoketest/scripts/cli/test_system_option.py Outdated Show resolved Hide resolved
@c-po
Copy link
Member

c-po commented Nov 6, 2024

@Mergifyio rebase

</valueHelp>
<valueHelp>
<format>virtual-guest</format>
<description>Tune for running inside a virtual guest</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<description>Tune for running inside a virtual guest</description>
<description>Tune for running inside a virtual machine</description>

You can run as a guest, but not inside it. If you are running inside a virtual machine, you are running as a guest.

<description>Tune for low network latency</description>
</valueHelp>
<valueHelp>
<format>powersave</format>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<format>powersave</format>
<format>power-save</format>

All other options separate words with hyphens, maybe this one should do that as well.

That will require a simple profile name mapping in the script, but we should probably do that anyway, since tuned profile names may change in the future.

</valueHelp>
<valueHelp>
<format>virtual-host</format>
<description>Tune for running KVM guests</description>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<description>Tune for running KVM guests</description>
<description>Tune for running guest virtual machines</description>

Theoretically, one still could use Xen, or some future hypervisor. I'd keep this generic.

Copy link

github-actions bot commented Nov 7, 2024

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests ❌ failed

@dmbaturin dmbaturin merged commit a975403 into vyos:current Nov 8, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants